Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] improve log and change verbosity parameter #96

Merged
merged 3 commits into from
Dec 16, 2022

Conversation

Remi-Gau
Copy link
Contributor

closes #95
closes #94

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 15, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 1.36%.

Quality metrics Before After Change
Complexity 4.17 ⭐ 3.73 ⭐ -0.44 👍
Method Length 80.06 🙂 74.02 🙂 -6.04 👍
Working memory 6.95 🙂 6.95 🙂 0.00
Quality 70.17% 🙂 71.53% 🙂 1.36% 👍
Other metrics Before After Change
Lines 1306 1115 -191
Changed files Quality Before Quality After Quality Change
bidsmreye/download.py 65.08% 🙂 69.91% 🙂 4.83% 👍
bidsmreye/generalize.py 65.71% 🙂 64.54% 🙂 -1.17% 👎
bidsmreye/prepare_data.py 68.02% 🙂 67.24% 🙂 -0.78% 👎
bidsmreye/utils.py 73.46% 🙂 74.00% 🙂 0.54% 👍
tests/test_generalize.py 90.60% ⭐ 90.60% ⭐ 0.00%
tests/test_methods.py 93.85% ⭐ 93.85% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bidsmreye/generalize.py process_subject 5 ⭐ 277 ⛔ 12 😞 45.46% 😞 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/utils.py Config.check_argument 11 🙂 177 😞 9 🙂 51.74% 🙂 Try splitting into smaller methods
bidsmreye/utils.py Config.__attrs_post_init__ 9 🙂 214 ⛔ 7 🙂 55.23% 🙂 Try splitting into smaller methods
bidsmreye/utils.py check_layout 9 🙂 148 😞 9 🙂 56.40% 🙂 Try splitting into smaller methods
bidsmreye/download.py download 9 🙂 158 😞 8 🙂 57.58% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #96 (19424d4) into main (6580b73) will decrease coverage by 49.80%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #96       +/-   ##
==========================================
- Coverage   49.80%   0.00%   -49.81%     
==========================================
  Files           7       7               
  Lines         504     524       +20     
  Branches       77       0       -77     
==========================================
- Hits          251       0      -251     
- Misses        226     524      +298     
+ Partials       27       0       -27     
Flag Coverage Δ
tests 0.00% <0.00%> (-49.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bidsmreye/bidsmreye.py 0.00% <0.00%> (ø)
bidsmreye/download.py 0.00% <0.00%> (ø)
bidsmreye/generalize.py 0.00% <0.00%> (-46.35%) ⬇️
bidsmreye/prepare_data.py 0.00% <0.00%> (-50.65%) ⬇️
bidsmreye/utils.py 0.00% <0.00%> (-67.72%) ⬇️
bidsmreye/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
bidsmreye/methods.py 0.00% <0.00%> (-90.00%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau merged commit 31eaf50 into cpp-lln-lab:main Dec 16, 2022
@Remi-Gau Remi-Gau deleted the misc branch December 17, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use v instead of log level for verbosity Use relative path in log output
1 participant