Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] openneuro demo, add run argument, use pybids database... #58

Merged
merged 13 commits into from
Jul 28, 2022

Conversation

Remi-Gau
Copy link
Contributor

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Jul 28, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.09%.

Quality metrics Before After Change
Complexity 3.16 ⭐ 3.72 ⭐ 0.56 👎
Method Length 63.92 🙂 68.01 🙂 4.09 👎
Working memory 6.66 🙂 6.91 🙂 0.25 👎
Quality 74.48% 🙂 72.39% 🙂 -2.09% 👎
Other metrics Before After Change
Lines 1352 1561 209
Changed files Quality Before Quality After Quality Change
bidsmreye/combine.py 60.53% 🙂 58.54% 🙂 -1.99% 👎
bidsmreye/generalize.py 50.26% 🙂 65.28% 🙂 15.02% 👍
bidsmreye/methods.py 80.15% ⭐ 80.15% ⭐ 0.00%
bidsmreye/prepare_data.py 71.88% 🙂 70.28% 🙂 -1.60% 👎
bidsmreye/run.py 43.28% 😞 37.77% 😞 -5.51% 👎
bidsmreye/utils.py 78.52% ⭐ 74.29% 🙂 -4.23% 👎
docs/source/conf.py 79.18% ⭐ 79.05% ⭐ -0.13% 👎
tests/test_combine.py 96.07% ⭐ 96.07% ⭐ 0.00%
tests/test_generalize.py 92.44% ⭐ 92.44% ⭐ 0.00%
tests/test_utils.py 93.35% ⭐ 93.24% ⭐ -0.11% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bidsmreye/run.py main 16 🙂 482 ⛔ 12 😞 31.82% 😞 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/combine.py process_subject 4 ⭐ 242 ⛔ 15 😞 43.84% 😞 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/generalize.py process_subject 5 ⭐ 250 ⛔ 12 😞 46.69% 😞 Try splitting into smaller methods. Extract out complex expressions
bidsmreye/utils.py Config.check_argument 11 🙂 176 😞 9 🙂 51.83% 🙂 Try splitting into smaller methods
bidsmreye/utils.py check_layout 9 🙂 147 😞 9 🙂 56.51% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Remi-Gau Remi-Gau merged commit 2e1a788 into main Jul 28, 2022
@Remi-Gau Remi-Gau deleted the config_class branch July 28, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create pybids database of input layout update readme with docker info change doc style to sphinx
1 participant