Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile make (Sourcery refactored) #41

Merged
merged 3 commits into from
Jul 26, 2022
Merged

Dockerfile make (Sourcery refactored) #41

merged 3 commits into from
Jul 26, 2022

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Jul 26, 2022

Pull Request #40 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Incorporate changes via command line
    git fetch https://github.com/cpp-lln-lab/bidsMReye pull/40/head
    git merge --ff-only FETCH_HEAD
    git push

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from WeeXee July 26, 2022 10:02
Comment on lines 47 to +50
# if some requested participants are not found
subjects = layout_in.get_subjects()
if self.participant:
missing_subjects = list(set(self.participant) - set(subjects))
if missing_subjects:
if missing_subjects := list(set(self.participant) - set(subjects)):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function Config.__attrs_post_init__ refactored with the following changes:

@pep8speaks
Copy link

Hello @sourcery-ai[bot]! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 50:33: E231 missing whitespace after ':'
Line 50:33: E701 multiple statements on one line (colon)
Line 50:34: E225 missing whitespace around operator
Line 66:30: E231 missing whitespace after ':'
Line 66:30: E701 multiple statements on one line (colon)
Line 66:31: E225 missing whitespace around operator

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Jul 26, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.04%.

Quality metrics Before After Change
Complexity 4.57 ⭐ 4.41 ⭐ -0.16 👍
Method Length 48.55 ⭐ 48.36 ⭐ -0.19 👍
Working memory 6.68 🙂 6.90 🙂 0.22 👎
Quality 75.55% 75.59% 0.04% 👍
Other metrics Before After Change
Lines 199 194 -5
Changed files Quality Before Quality After Quality Change
bidsmreye/utils.py 75.55% ⭐ 75.59% ⭐ 0.04% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
bidsmreye/utils.py Config.__attrs_post_init__ 10 🙂 161 😞 9 🙂 54.14% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@Remi-Gau Remi-Gau merged commit 110cb0d into main Jul 26, 2022
@Remi-Gau Remi-Gau deleted the sourcery/pull-40 branch July 26, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants