Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grants.md #68

Merged
merged 2 commits into from
Dec 5, 2024
Merged

Update grants.md #68

merged 2 commits into from
Dec 5, 2024

Conversation

EleGdt
Copy link
Contributor

@EleGdt EleGdt commented Oct 30, 2024

I copied paste last two paragraphs.
I think the PhD/Post Doc/Other should be moved somewhere else. There is a link to our google drive that is not private, I do not know how to change privacy settings.

I copied paste last two paragraphs. 
I think the PhD/Post Doc/Other should be moved somewhere else.
There is a link to our google drive that is not private, I do not know how to change privacy settings.
Copy link
Contributor

@fcerpe fcerpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to keep the title / subtitles structure similar to other pages.
FYI the more '#', the less important a part is:

Title - '#'

Section - '##'

Paragraph - '###'

@@ -42,3 +42,35 @@ should submit one month before the conference.

### WBI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fcerpe as discussed already, I will remove your suggestion since they are not in line with the MD title/paragraph/etc structure

@avanaudenhaege
Copy link
Contributor

Base automatically changed from EleGdt-patch-2 to main November 28, 2024 19:53
@marcobarilari
Copy link
Contributor

marcobarilari commented Nov 28, 2024

Thank you @EleGdt and @avanaudenhaege, will review and answer in separate comments in few minutes

@@ -42,3 +42,35 @@ should submit one month before the conference.

### WBI
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fcerpe as discussed already, I will remove your suggestion since they are not in line with the MD title/paragraph/etc structure

@cpp-lln-lab cpp-lln-lab deleted a comment from fcerpe Nov 28, 2024
@marcobarilari
Copy link
Contributor

@EleGdt I let you approve (or not the edits) and @avanaudenhaege check if that is the link you want to change, thanks!

Co-authored-by: Marco Barilari <38101692+marcobarilari@users.noreply.github.com>
@marcobarilari marcobarilari merged commit b7e993a into main Dec 5, 2024
@marcobarilari marcobarilari deleted the EleGdt-patch-3 branch December 5, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants