Externally remove deprecated AtomicLongMapSubject, DefaultSubject…

…, `StandardSubjectBuilder.fail(...)` overload that accepts arguments, and `Optional*Subject.hasValueThat()`

Fixes google#204

Relnotes:
  - Removed the overload of `StandardSubjectBuilder.fail(...)` that accepts a message. Instead of `assert_().fail(...)`, use `assertWithMessage(...).fail()`. Similarly, instead of `expect.fail(...)`, use `expect.withMessage(...).fail()`, and so forth.
  - Removed `DefaultSubject`. Use plain `Subject`.
  - Removed `Optional*Subject.hasValueThat()`. Instead of `assertThat(optional).hasValueThat()....`, use `assertThat(optional.getAs*())....`.
  - Removed `AtomicLongMapSubject`. In most cases, you can [assert on the `asMap()` view instead](google#579).

[]

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=254994279

core/src/main/java/com/google/common/truth/StandardSubjectBuilder.java

@@ -23,7 +23,6 @@
 import com.google.common.collect.Multimap;
 import com.google.common.collect.Multiset;
 import com.google.common.collect.Table;
-import com.google.common.util.concurrent.AtomicLongMap;
 import java.math.BigDecimal;
 import java.util.Map;
 import org.checkerframework.checker.nullness.compatqual.NullableDecl;
@@ -171,12 +170,6 @@ public final TableSubject that(@NullableDecl Table<?, ?, ?> actual) {
     return new TableSubject(metadata(), actual);
   }
 
-  /** @deprecated Perform assertions on the {@link AtomicLongMap#asMap()} view. */
-  @Deprecated
-  public final AtomicLongMapSubject that(@NullableDecl AtomicLongMap<?> actual) {
-    return new AtomicLongMapSubject(metadata(), actual);
-  }
-
   /**
    * Returns a new instance that will output the given message before the main failure message. If
    * this method is called multiple times, the messages will appear in the order that they were
@@ -228,18 +221,6 @@ public final void fail() {
     metadata().fail(ImmutableList.<Fact>of());
   }
 
-  /**
-   * Reports a failure with the given message.
-   *
-   * @deprecated Instead of {@code assert_().fail(...)}, use {@code assertWithMessage(...).fail()}.
-   *     Similarly, instead of {@code expect.fail(...)}, use {@code expect.withMessage(...).fail()},
-   *     and so forth.
-  */
-  @Deprecated
-  public final void fail(String format, Object /*@NullableDeclType*/... args) {
-    withMessage(format, args).fail();
-  }
-
   private FailureMetadata metadata() {
     checkStatePreconditions();
     return metadataDoNotReferenceDirectly;

core/src/main/java/com/google/common/truth/ThrowableSubject.java

@@ -69,7 +69,9 @@ public final ThrowableSubject hasCauseThat() {
     // TODO(diamondm) in keeping with other subjects' behavior this should still NPE if the subject
     // *itself* is null, since there's no context to lose. See also b/37645583
     if (actual == null) {
-      check("getCause()").fail("Causal chain is not deep enough - add a .isNotNull() check?");
+      check("getCause()")
+          .withMessage("Causal chain is not deep enough - add a .isNotNull() check?")
+          .fail();
       return ignoreCheck()
           .that(
               new Throwable() {

core/src/main/java/com/google/common/truth/Truth.java

@@ -22,7 +22,6 @@
 import com.google.common.collect.Multimap;
 import com.google.common.collect.Multiset;
 import com.google.common.collect.Table;
-import com.google.common.util.concurrent.AtomicLongMap;
 import java.math.BigDecimal;
 import java.util.Map;
 import org.checkerframework.checker.nullness.compatqual.NullableDecl;
@@ -242,13 +241,6 @@ public static TableSubject assertThat(@NullableDecl Table<?, ?, ?> actual) {
     return assert_().that(actual);
   }
 
-  /** @deprecated Perform assertions on the {@link AtomicLongMap#asMap()} view. */
-  @Deprecated
-  public static AtomicLongMapSubject assertThat(
-      @NullableDecl AtomicLongMap<?> actual) {
-    return assert_().that(actual);
-  }
-
   /**
    * An {@code AssertionError} that (a) always supports a cause, even under old versions of Android
    * and (b) omits "java.lang.AssertionError:" from the beginning of its toString() representation.