move para about write-env into write-env's itemdescr #7559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a paragraph about _`write-env`_ from P3396R1 got accidentally added outside of _`write-env`_'s `itemdescr`. move it inside.
jensmaurer
approved these changes
Jan 12, 2025
|
The change seems fine, but it produces an overfull \hbox due to added indentation: 2025-01-12T04:18:15.0341238Z ##[error]Overfull \hbox (7.76248pt too wide) in paragraph at lines 1903--1908 @ericniebler , please fix. |
jensmaurer
added
the
changes requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a paragraph about
write-envfrom P3396R1 got accidentally added outside ofwrite-env'sitemdescr. move it inside.