Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lex.header] Modernize text around header names #7336

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

AlisdairM
Copy link
Contributor

@AlisdairM AlisdairM commented Oct 21, 2024

The footnote better belongs in the main text as a regular note.
To make the notes flow consistently, switch the order of the
note and normative text in the first paragraph to lead with the
normative text.

source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
@AlisdairM AlisdairM force-pushed the impdef_header_names branch from 2712ba4 to b272f17 Compare October 21, 2024 13:24
@AlisdairM AlisdairM changed the title [lex.header] Index both implementation-defined behaviors [lex.header] Modernize text around header names Oct 21, 2024
@AlisdairM AlisdairM force-pushed the impdef_header_names branch from b272f17 to 78681d6 Compare October 21, 2024 17:36
@AlisdairM
Copy link
Contributor Author

Flagging that I believe I have addressed the changes requested by Jens.

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 19, 2024

Editorial meeting discussion in Wroclaw 2024:

There does not seem to be a simple, context-free rule for how to spell characters (such as "always use the unicode named reference"). There cases where we definitely want the named reference, such as in the lexer grammar. There are also cases where the literal character is most appropriate, such as in "the unary & operator". In the present proposed change, having / adjacent to the two-character /*, which we'd never consider spelling as a sequence of named references, seems to be entirely clear.

Therefore, we don't want any kind of context-free blanket replacement of characters with named unicode references, or vice versa. It is possible that we can identify a more nuanced rule when to apply.

The footnote better belongs in the main text as a regular note.
To make the notes flow consistently, switch the order of the
note and normative text in the first paragraph to lead with the
normative text.
@AlisdairM
Copy link
Contributor Author

Removed the last part of the Unicode markup changes from the original commit message:
" Finally, take this opportunity to clarify the specific characters called out using the Unicode nomenclature used throughout this clause."

@tkoeppe tkoeppe requested a review from jensmaurer November 20, 2024 00:23
@tkoeppe tkoeppe merged commit 2edf50a into cplusplus:main Nov 21, 2024
2 checks passed
@AlisdairM AlisdairM deleted the impdef_header_names branch November 21, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants