Converted source/extensions/outlier_detection_monitors/common to libr…

…ary. Signed-off-by: Christoph Pakulski <paker8848@gmail.com>
cpakulski · Jul 25, 2024 · af13f3f · af13f3f
1 parent 238ed19
commit af13f3f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 15 deletions.
diff --git a/api/envoy/extensions/outlier_detection_monitors/common/v3/error_types.proto b/api/envoy/extensions/outlier_detection_monitors/common/v3/error_types.proto
@@ -13,7 +13,6 @@ option go_package = "github.com/envoyproxy/go-control-plane/envoy/extensions/out
 option (udpa.annotations.file_status).package_version_status = ACTIVE;
 
 // [#protodoc-title: Outlier detection error buckets]
-// [#extension: envoy.outlier_detection_monitors.common]
 
 // Outlier detection extensions require attaching error buckets. The purpose
 // of error buckets is describing which results should be of interest to

diff --git a/source/extensions/extensions_build_config.bzl b/source/extensions/extensions_build_config.bzl
@@ -316,7 +316,6 @@ EXTENSIONS = {
     # Outlier Detection Monitors
     #
     #
-    "envoy.outlier_detection_monitors.common":             "//source/extensions/outlier_detection_monitors/common:outlier_detection_monitors_lib",
     "envoy.outlier_detection_monitors.consecutive_errors": "//source/extensions/outlier_detection_monitors/consecutive_errors:consecutive_errors_monitor_lib",
 
     #

diff --git a/source/extensions/extensions_metadata.yaml b/source/extensions/extensions_metadata.yaml
@@ -984,12 +984,6 @@ envoy.matching.matchers.cel_matcher:
   status: stable
   type_urls:
   - xds.type.matcher.v3.CelMatcher
-envoy.outlier_detection_monitors.common:
-  categories:
-  - envoy.outlier_detection_monitors
-  security_posture: robust_to_untrusted_downstream
-  status: alpha
-  undocumented: true
 envoy.outlier_detection_monitors.consecutive_errors:
   categories:
   - envoy.outlier_detection_monitors

diff --git a/source/extensions/outlier_detection_monitors/common/BUILD b/source/extensions/outlier_detection_monitors/common/BUILD
@@ -1,25 +1,22 @@
 load(
     "//bazel:envoy_build_system.bzl",
-    "envoy_cc_extension",
-    "envoy_extension_package",
+    "envoy_cc_library",
 )
 
 licenses(["notice"])  # Apache 2
 
-envoy_extension_package()
-
-envoy_cc_extension(
+envoy_cc_library(
     name = "outlier_detection_monitors_lib",
     srcs = ["monitor_base_impl.cc"],
     hdrs = ["monitor_base_impl.h"],
-    extra_visibility = [
+    visibility = [
         "//source/common/upstream:__subpackages__",
+        "//source/extensions/outlier_detection_monitors:__subpackages__",
         "//test/common/upstream:__subpackages__",
     ],
     deps = [
         "//source/common/protobuf",
         "//source/common/protobuf:utility_lib_header",
-        #"//envoy/server:factory_context_interface",
         "@envoy_api//envoy/extensions/outlier_detection_monitors/common/v3:pkg_cc_proto",
     ],
 )