Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add helper function for defaultStopWords #50

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Add helper function for defaultStopWords #50

merged 2 commits into from
Oct 20, 2022

Conversation

valencik
Copy link
Collaborator

This PR adds a private helper function for calculating the defaultStopWords and moves the scaladoc to the abstract method to reduce boilerplate.

@valencik valencik self-assigned this Oct 20, 2022
@valencik valencik requested a review from samspills October 20, 2022 21:32
samspills
samspills approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@samspills samspills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very smart, I like it

@valencik valencik merged commit e016823 into main Oct 20, 2022
@valencik valencik deleted the add-toSet branch November 18, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samspills samspills samspills approved these changes

Assignees

@valencik valencik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valencik @samspills