Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add yet more languages #45

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Add yet more languages #45

merged 7 commits into from
Oct 20, 2022

Conversation

valencik
Copy link
Collaborator

@valencik valencik commented Oct 20, 2022

This PR adds Portuguese, Brazilian Portuguese, and Dutch AnalyzerBuilders.

Closes #32

@valencik valencik self-assigned this Oct 20, 2022
@valencik
Copy link
Collaborator Author

valencik commented Oct 20, 2022

Still need to:

  • add the "language switching" methods to DefaultAnalyzerBuilder

Perhaps these should be tested as well? Mainly that a configured DefaultAnalyzerBuilder carries over that config when a language is switched.

@valencik valencik merged commit bd24dae into main Oct 20, 2022
@valencik valencik deleted the langs-pt2 branch November 18, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a few more languages
1 participant