fix: Get correct bi mapping for bnp_es and cic_es #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade cozy-bi-auth package to 0.0.25. 0.0.24 was published without building the package
Crash--
reviewed
Apr 13, 2022
| @@ -18530,7 +18530,7 @@ react-router@5.2.0: | |||
| tiny-invariant "^1.0.2" | |||
| tiny-warning "^1.0.0" | |||
|
|
|||
| react-router@6, react-router@6.3.0: | |||
There was a problem hiding this comment.
I don't understand why you have this change 🤔
There was a problem hiding this comment.
Did not see that but I actually get the same change if I take the master and run yarn lerna clean && yarn install with yarn 1.22.18 and node 12.22.7
There was a problem hiding this comment.
this is a nit.
This PR can be approved
trollepierre
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade cozy-bi-auth package to 0.0.25. 0.0.24 was published without
building the package