fix: Prevent cookie duplication when calling /apps/:slug/open
#425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
approved these changes
Sep 30, 2022
Ldoppea
force-pushed
the
fix/prevent_cookie_duplication
branch
from
ed1f6a0 to
110b3a1
Compare
`cozy-client` as been upgraded to to `33.2.0` to retrieve ability to override stack-client's `options.credentials` from cozy/cozy-client#1250
In some scenario (mainly in production) we observed that cookie was duplicated in the HTTP headers. Also both cookies were separated by a comma instead of a semicolon This form is not supported by cozy-stack and the result is that the cozy-stack consider the request is not cookie-authenticated So when calling `/apps/:slug/open`, a new generated cookie would be returned instead of the provided one as expected in #277 To fix this we want to specify `credentials:omit` into the fetch options, this would prevent react-native to inject a copy of the same cookie More info: facebook/react-native#23185 (comment)
Ldoppea
force-pushed
the
fix/prevent_cookie_duplication
branch
from
110b3a1 to
f3915c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some scenario (mainly in production) we observed that cookie was duplicated in the HTTP headers. Also both cookies were separated by a comma instead of a semicolon
This form is not supported by cozy-stack and the result is that the cozy-stack consider the request is not cookie-authenticated
So when calling
/apps/:slug/open, a new generated cookie would be returned instead of the provided one as expected in #277To fix this we want to specify
credentials:omitinto the fetch options, this would prevent react-native to inject a copy of the same cookieMore info: facebook/react-native#23185 (comment)
TODO:
credentialvalue infetchJSON()options cozy-client#1250 is merged