fix(stack-client): Get Icon Url uses preloaded url when oAuth not needed #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crash--
reviewed
Feb 25, 2022
trollepierre
force-pushed
the
getIconUrl
branch
from
1f7a7ea to
98ab044
Compare
trollepierre
commented
Feb 28, 2022
| defaultOpts.appData = 'appData-that-is-a-string' | ||
| const url = await getIconURL(stackClient, defaultOpts) | ||
| expect(url).toEqual( | ||
| 'http://cozy.tools:8080/registry/appData-that-is-a-string/icon' |
There was a problem hiding this comment.
@Crash-- : I wonder if this appData that can be string is possible
There was a problem hiding this comment.
this code + test have been removed
trollepierre
force-pushed
the
getIconUrl
branch
from
98ab044 to
e9bd7ea
Compare
trollepierre
commented
Feb 28, 2022
| } else { | ||
| try { | ||
| const { host: domain, protocol } = new URL(stackClient.uri) | ||
| return loadIcon(appData, domain, protocol) |
There was a problem hiding this comment.
appData now mandatory to be able to be executed simply => https://github.com/cozy/cozy-ui/pull/2064/files
Crash--
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need upgrade in cozy-ui as well + test + working without breaking change
cozy/cozy-ui#2064