Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish type definitions (fixes #45) #46

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Publish type definitions (fixes #45) #46

merged 1 commit into from
Feb 22, 2018

Conversation

cozmo
Copy link
Owner

@cozmo cozmo commented Feb 22, 2018

Previously I think this was not doing what was expected, specifically we weren't actually including anything in the dist folder. Rather dist/jsQR.js was being included only because it was listed as the entry point in package.json. This change is now correctly including any files in the dist folder.

Can be verified by running npm pack and then seeing the output is expected.

@cozmo cozmo requested a review from jefff February 22, 2018 04:39
@cozmo cozmo merged commit 9b1c831 into master Feb 22, 2018
@cozmo cozmo deleted the publish-types branch February 22, 2018 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants