Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scanning problem #59

Closed
we820731 opened this issue Jun 13, 2018 · 3 comments · Fixed by #67
Closed

Scanning problem #59

we820731 opened this issue Jun 13, 2018 · 3 comments · Fixed by #67

Comments

@we820731
Copy link

image
The right picture cannot be scanned.
How to solve this problem?
@cozmo
Copy link
Owner

cozmo commented Jun 25, 2018

Ah this is the same issue as #54, bad handling of inverted QR codes (white on black not black on white). I have a fix out for this but have to re-work some of the test framework to support it. I'll keep you posted.

@cozmo cozmo mentioned this issue Jun 28, 2018
Merged
@cozmo cozmo closed this as completed in #67 Jun 28, 2018
@cozmo
Copy link
Owner

cozmo commented Jun 28, 2018

The fix for this (supporting inverted QR codes) was published as version 1.0.5 on npm. Thanks for the report!

@Doktor-Avalanche
Copy link

Doktor-Avalanche commented Dec 16, 2018 •
edited
Loading

I'm trying the demo at https://cozmo.github.io/jsQR/ with my QR-code, which is white on black, but it doesn't decode. Others (Black on White) are decoded fine. Should this demo also decode white on black QR-codes? I also tried the library at my own with the same results. Someone an idea how to resolve?
Edit : It seems to work, but it is less 'sensitive'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support inverted QR codes cozmo/jsQR
3 participants
@cozmo @Doktor-Avalanche @we820731