Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I cannot decode this image. #54

Open
ITsolution-git opened this issue Mar 26, 2018 · 5 comments
Open

I cannot decode this image. #54

ITsolution-git opened this issue Mar 26, 2018 · 5 comments

Comments

@ITsolution-git
Copy link

screenshot from 2018-03-25 13 57 21
screenshot from 2018-03-26 16 19 11
Would you please help me?
The jsQr gives me error with these images?
Especially on colored qr codes.

Thank you in advance.

@cozmo
Copy link
Owner

cozmo commented Apr 5, 2018

Odd, we have some issues with QR codes with lines around the squares tracked in #14 that could impact the second image, but I think there's something else going on, I'm investigating.

@cozmo
Copy link
Owner

cozmo commented May 18, 2018

Both these images seem to be related to the contrast ratio - the first one the contrast ratio is low and the second is being thrown off because the traditionally black squares are white - it's basically inverted.

Both of these issues should be able to be solved - I added test cases here - 9c8a6f0 and so we'll start to see the tests pass as we improve the detection with relation to contrast ratios.

@ITsolution-git
Copy link
Author

Awesome. Thank you @cozmo.

This was referenced Jun 25, 2018
@cozmo
Copy link
Owner

cozmo commented Jun 28, 2018

Now that #67 has been merged we're...closer. Still failing to binarize your images though I think, which is odd. Will let you know when this issue is resolved.

@ITsolution-git
Copy link
Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants