Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add order ref to all logs #43

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Add order ref to all logs #43

merged 5 commits into from
Sep 22, 2023

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Sep 21, 2023

Description

While debugging, i realised it was hard to follow and filter all the logs relatively to a single order.

As we can see here, some logs refer to some internal reference, but not all logs include it:
image

In this case, its hard for me to say if the API call is for that specific order.

Printing all the static input or the TX in each log is too verbose. This is why we give the order on each run a unique identifier:
ownerCount.orderCount@block

This will allow to find the order we want (by TX hash for example). After that we can filter for just that order and block easily

This is an example of an OUTPUT after the changes in this PR:
image

Result

This will make it super easy to check:

  • All logs from a single block: Search for @29779465, being 29779465 the block we want to see
  • All logs regarding one specific order: 1.5@29779465 being 1 the owner internal count, and 5 the internal count for the order.

@github-actions
Copy link

github-actions bot commented Sep 21, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@anxolin anxolin marked this pull request as ready for review September 21, 2023 15:44
@anxolin
Copy link
Contributor Author

anxolin commented Sep 21, 2023

I have read the CLA Document and I hereby sign the CLA

@anxolin anxolin requested review from mfw78 and alfetopito September 21, 2023 15:56
github-actions bot added a commit that referenced this pull request Sep 21, 2023
@anxolin anxolin requested a review from a team September 21, 2023 15:57
@anxolin anxolin merged commit b14363c into main Sep 22, 2023
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
@alfetopito alfetopito deleted the add-log-refs branch September 22, 2023 10:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant