feat: add metric for the latest block from the chain (tip) #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cowprotocol/frontend , merging to test this, but please review anyways |
alfetopito
reviewed
Dec 9, 2024
Comment on lines
193
to
+196
| let currentBlock = await provider.getBlock("latest"); | ||
| metrics.blockHeightLatest | ||
| .labels(chainId.toString()) | ||
| .set(currentBlock.number); |
There was a problem hiding this comment.
Nitpick: since this is repeated 3 times, would it be worth it to wrap around a fn? Just so we don't forget to track the metrics if we want to use this elsewhere.
There was a problem hiding this comment.
sorry, i saw it only after merging. The whole code needs some serious refactoring. Lets clean it up all in the future 🙏
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up on #171
This PR adds the latest mined block (tip of the chain).
It allow us to build a burn-down chart on how far we are from the chain (as we consume blocks).
This is useful to see that indeed the slope is downwards.
Otherwise, we won't arrive to the tip of the chain! 😄
Changes
Include a new metric
EDIT: 🚨 I had to make a follow up to this PR here #173