Ignore slippage for settlements with ERC404 tokens #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no other token seems to have been traded via cow protocol
fhenneke
changed the title
harisang
reviewed
Feb 12, 2024
harisang
reviewed
Feb 12, 2024
| or 0x6C061D18D2b5bbfBe8a8D1EEB9ee27eFD544cC5D in (buy_token, sell_token) -- exclude MNRCH | ||
| or 0xbE33F57f41a20b2f00DEc91DcC1169597f36221F in (buy_token, sell_token) -- exclude Rug | ||
| or 0x938403C5427113C67b1604d3B407D995223C2B78 in (buy_token, sell_token) -- exclude OOZ | ||
| ) |
There was a problem hiding this comment.
Suggested change
| ) | |
| or 0x54832d8724f8581e7Cc0914b3A4e70aDC0D94872 in (buy_token, sell_token) -- exclude DN404 | |
| ) |
There was a problem hiding this comment.
one more such token (hope i didn't mess with the spacing)
|
Looks good! |
harisang
approved these changes
Feb 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #340 by explicitly excluding settlements from slippage which trade the ERC404 tokens 404, Pandora, Monarch, and Rug. No other ERC404 tokens seem to have been traded on CoW Protocol until all of them were blocked in the backend.