Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve description when posting transaction on slack #472

Closed
harisang opened this issue Dec 24, 2024 · 1 comment
Closed

Improve description when posting transaction on slack #472

harisang opened this issue Dec 24, 2024 · 1 comment
Labels
E:9.1 Streamline mainnet payouts process See https://github.com/cowprotocol/pm/issues/80 for details

Comments

@harisang
Copy link
Contributor

Given the script now runs on multiple chains, we should add a more descriptive message (referencing the network) when posting the transaction on Slack

solver-rewards/src/fetch/transfer_file.py

Line 104 in 6538cc0

message=(

@harisang harisang added the E:9.1 Streamline mainnet payouts process See https://github.com/cowprotocol/pm/issues/80 for details label Dec 24, 2024
@harisang harisang mentioned this issue Dec 24, 2024
Merged
fhenneke pushed a commit that referenced this issue Jan 10, 2025
@harisang
Add more info in slack message (#475)
5959eaf 
This PR adds a bit more info in the final logging messages.

~~PR #474 needs to be merged first, so marking as draft for now~~

This PR addresses issue #472
@harisang
Copy link
Contributor Author

Completed via PR #475

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:9.1 Streamline mainnet payouts process See https://github.com/cowprotocol/pm/issues/80 for details
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@harisang