Remove obsolete solver competition data

[fleupold]

Description

Now that we collect all the competition data we care about going forward, we can remove the obsolete fields. Changes should be backwards compatible as Options will be parsed as Some if present and extra fields that remain in the json that is stored in the DB will be ignored. Very old auctions for which we don't store ranking or score will fail to load (but that's acceptable IMO)

Changes

• Make it so that we don't log calldata fields that don't exist for non-winners.
• Remove objective as it's not recorded for runners up (and isn't really relevant just for the winner). All we care about now is score
• Remove gasPrice and liquidityFetchedBlock as they don't exist anymore.
• Make mandatory score and ranking non-optional
• Add e2e test for multiple solver solutions

How to test

Run e2e test

Related Issues

Fixes #1949

[sunce86]

@harisang Is it ok to completely remove the Objective section? It is true that the protocol now only cares about the score (based on CIP20), but what will be the status after ranking by surplus? Also, for debugging it might be useful to capture surplus and fees from the onchain settlement.

[harisang]

Am i correct to assume that moving forward, what we report in the competition endpoint should be from the point of view of the autopilot only? If so, I agree "gasPrice" and "liquidity fetching block" should be removed, and also I don't think we need the objective anymore. Score should always represent the value according to which solutions are getting ranked, and this should be sufficient

[fleupold]

Am i correct to assume that moving forward, what we report in the competition endpoint should be from the point of view of the autopilot only?

I think so. At the end of the day all data we want to log here we either need to receive from the driver or index ourselves. Since the autopilot shouldn't worry about liquidity going forward, it would have to be passed up from drivers (which in most cases doesn't make sense, since not all drivers fetch liquidity in the first place)