Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Rename fallible constructors #3179

Closed
sunce86 opened this issue Dec 23, 2024 · 2 comments
Closed

chore: Rename fallible constructors #3179

sunce86 opened this issue Dec 23, 2024 · 2 comments
Assignees
@p-andhika
Labels
good first issue Good for newcomers track:maintenance maintenance track

Comments

@sunce86
Copy link
Contributor

sunce86 commented Dec 23, 2024

Background

Reference: #3173 (comment)

all constructors that return Result should be renamed to try_new.
@sunce86 sunce86 added good first issue Good for newcomers track:maintenance maintenance track labels Dec 23, 2024
@sunce86 sunce86 mentioned this issue Dec 23, 2024
Merged
2 tasks
@p-andhika p-andhika mentioned this issue Dec 31, 2024
Merged
1 task
@p-andhika
Copy link
Contributor

@sunce86 I've raised an inital PR here for this issue: #3199

MartinquaXD pushed a commit that referenced this issue Jan 2, 2025
@p-andhika @squadgazzz
Rename constructors to try_new (#3199)
0ff75fa 
# Description
This PR try to tackle issue #3179.

# Changes
- [ ] Rename all constructors that return `Result` to `try_new`.

## How to test
Existing unit test.

---------

Co-authored-by: ilya <ilya@cow.fi>
@0xi4h 0xi4h mentioned this issue Jan 2, 2025
Closed
3 tasks
@sunce86
Copy link
Contributor Author

sunce86 commented Jan 10, 2025

#3199

@sunce86 sunce86 closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p-andhika p-andhika

Labels
good first issue Good for newcomers track:maintenance maintenance track
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sunce86 @p-andhika