Skip to content

Commit

Permalink
Revert executing eth_estimateGas and eth_createAccessList on the …
Browse files Browse the repository at this point in the history
…latest block (#3227)

While this PR would give us revert detection reproducible with tenderly
it also leads to an overly optimistic revert protection. Meaning on
average future reverts get detected too late which would result in
solvers losing a lot of money.

This was noticed by an external solver running the original PR in
production and seeing their rewards vanish due to increased reverts.

See this
[thread](https://cowservices.slack.com/archives/C0690QX4R5X/p1736368423899369?thread_ts=1736279159.869429&cid=C0690QX4R5X)
for reference.
  • Loading branch information
MartinquaXD authored Jan 9, 2025
1 parent 672b30f commit d13627d
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions crates/driver/src/infra/blockchain/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -182,10 +182,7 @@ impl Ethereum {
.transport()
.execute(
"eth_createAccessList",
vec![
serde_json::to_value(&tx).unwrap(),
serde_json::Value::String("latest".into()),
],
vec![serde_json::to_value(&tx).unwrap()],
)
.await?;
if let Some(err) = json.get("error") {
Expand All @@ -210,7 +207,7 @@ impl Ethereum {
gas_price: self.simulation_gas_price().await,
..Default::default()
},
Some(ethcontract::BlockNumber::Latest),
None,
)
.await
.map(Into::into)
Expand Down

0 comments on commit d13627d

Please sign in to comment.