This repository has been archived by the owner on Feb 2, 2024. It is now read-only.
feat(app-data): upgrade to latest appData version 1.1.0 #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shoom3301
approved these changes
Oct 19, 2023
Pull Request Test Coverage Report for Build 6574800324
💛 - Coveralls |
|
The buttons for the hooks look weird to me. Shouldn't they have some text on them, like "add" or "delete"? |
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
That's what I mean in the notes section 😅 |
anxolin
approved these changes
Oct 19, 2023
Well, kind of. |
alfetopito
force-pushed
the
upgrade-to-latest-app-data
branch
from
986a6fb to
4b9157c
Compare
alfetopito
commented
Oct 31, 2023
Comment on lines
+122
to
+140
| i.glyphicon { | ||
| display: none; | ||
| } | ||
| .btn-add::after { | ||
| content: 'Add'; | ||
| } | ||
| .array-item-copy::after { | ||
| content: 'Copy'; | ||
| } | ||
| .array-item-move-up::after { | ||
| content: 'Move Up'; | ||
| } | ||
| .array-item-move-down::after { | ||
| content: 'Move Down'; | ||
| } | ||
| .array-item-remove::after { | ||
| content: 'Remove'; | ||
| } | ||
|
|
shoom3301
reviewed
Nov 1, 2023
shoom3301
approved these changes
Nov 1, 2023
alfetopito
added a commit
that referenced
this pull request
Nov 1, 2023
* feat(app-data): upgrade to latest appData version 1.1.0 * chore: show appData array buttons * chore: comment out ipfs stuff * refactor: remove stuff that's not needed and remove some `any`s * refactor: sort imports * chore: remove IPFS reference * refactor: format
alfetopito
added a commit
that referenced
this pull request
Nov 1, 2023
* feat(app-data): upgrade to latest appData version 1.1.0 * chore: show appData array buttons * chore: comment out ipfs stuff * refactor: remove stuff that's not needed and remove some `any`s * refactor: sort imports * chore: remove IPFS reference * refactor: format
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update 2023-10-31
After lots of digging, found out what I needed to update: https://rjsf-team.github.io/react-jsonschema-form/docs/advanced-customization/internals/#custom-array-field-buttons
Now we have add, remove, move up/down buttons!
Summary
Upgrade to latest appData version 1.1.0
It contains the new metadata fields:
hooksandsignerTo Test
Notes