Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EASY] Change slippage wrapper for consistency with old slippage query #49

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

fhenneke
Copy link
Contributor

This PR makes the slippage query wrapper consistent with the old slippage query.

  • The blockchain parameter is set to ethereum. With this change, solver rewards does not have to add an additional parameter right now when querying slippage.
  • The return type is changed to floating point numbers. This removes the need to have an additional conversion from within solver rewards.

This wrapper will be removed once we have to time to adapt the solver rewards script to the format of the new slippage query (or we remove that query and use a local database).

@harisang
Copy link
Contributor

@fhenneke I don't see any change related to this

The return type is changed to floating point numbers. This removes the need to have an additional conversion from within solver rewards.

Copy link
Contributor

@harisang harisang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably forgot to include the edit on the slippage query

@fhenneke
Copy link
Contributor Author

Probably forgot to include the edit on the slippage query

True. I pushed that fix as well now.

Copy link
Contributor

@harisang harisang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but i guess this fix should be either on the 4070065 query side or in the payouts script itself

@fhenneke
Copy link
Contributor Author

I think the slippage query itself should use integers.

At some point we need to change the solver rewards script to handle those values correctly. Until then, this wrapper provides compatibility with the current version of solver rewards.

@fhenneke fhenneke merged commit 075ecbb into main Sep 23, 2024
1 check passed
@fhenneke fhenneke deleted the slippage_wrapper_fix branch September 23, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants