Cowamm/univ2 multichain #48
Merged
+79
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harisang
reviewed
Sep 27, 2024
| @@ -17,15 +17,43 @@ with date_range as ( | |||
| ), | |||
|
|
|||
| -- Finds the uniswap v2 pool address given tokens specified in query parameters (regardless of order) | |||
| pool as ( | |||
| pools as ( | |||
There was a problem hiding this comment.
Is it possible that a pool is created, then closed, and then created again? If so, i guess this table would pick on all of these created pools. Not sure if it can ever happen but in that case i guess we should pick the latest creation log.
There was a problem hiding this comment.
Ah ok, here you actually assume that there might be more than 1, and this is also why you switched the name to "pools" instead of "pool". I guess i was wondering whether it might be that we are picking on pools that are non-existent anymore, but maybe that's fine.
harisang
approved these changes
Sep 27, 2024
|
Combined the two queries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The curated events tables don't follow a consistent format making it hard to abstract away the chain for different networks. Luckily the logic for indexing base events is very simple and can be done using the raw
logstable (which does follow consistent naming.Changes
Test Plan
We now have reference pool data on Gnosis Chain