Use full bonding pools subquery in service fee tracker query #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhenneke
approved these changes
Sep 17, 2024
| from_hex('0x5d4020b9261F01B6f8a45db929704b0Ad6F5e9E6') as pool, | ||
| 'CoW Services' as pool_name, | ||
| from_hex('0x423cec87f19f0778f549846e0801ee267a917935') as initial_funder | ||
| pool_address as pool, |
There was a problem hiding this comment.
There should probably be an issue about making the naming consistent here and in solver-rewards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a small issue with the hardcoded full bonds in the Service Fee Tracker query (4017925), where the Project Blanc bonding pool was missing. The issue is fixed by pulling the bonds from the dedicated query we have that computes all full bonds.