List individual builders when notifying about posted bill #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowanator
approved these changes
Aug 17, 2024
fleupold
force-pushed
the
optional_draft_execute
branch
from
b341c0a
to
f212e7c
Compare
fleupold
force-pushed
the
better_billing_message
branch
from
b09b40c
to
ee748bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only thing the slack notification contains is a link to the transaction (making it difficult to understand how much each biller was billed in absolute terms).
This PR improves the message to contain for each builder label the amount formatted to whole ETH units.
Test Plan
Run on Sepolia, see