Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bond Map #29

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Remove Bond Map #29

merged 4 commits into from
Aug 16, 2024

Conversation

cowanator
Copy link
Collaborator

Removes extraneous environment variable BOND_MAP in favour of putting these values directly into the payment query. Closes #24

Additional Notes:

I went looking through this billing query to try and find the "source" of this BOND_MAP we want to remove:

My guess is that it hasn't been recorded in a Dune query yet - so I propose a PR that hard-codes this value instead of having it as a query parameter. This will eliminate the need for the additional environment variable.

Test Plan

Existing CI

@cowanator cowanator requested a review from fleupold August 3, 2024 13:37
@fleupold
Copy link
Contributor

fleupold commented Aug 6, 2024

cc @olgafetisova can you comment on what's the best way is to rely this Bonding pool solver mapping in Dune?

@cowanator
Copy link
Collaborator Author

cowanator commented Aug 9, 2024

I've spoken with @olgafetisova who is in the process of adding a bond_provider column to the BlockBuilders data table.

Then we will be able to query it from a source that combines all the runtime parameters without hard-coding these values into this query:

select distinct
  miner_biller_address as billing_account,
  bond_provider as initial_funder
from
query_3976545 -- This is my fork
-- query_3665113 
where
  bond_provider is not null

I'll update the code now (although it won't pass CI until that column exists).

So now the query has been updated and prepared for the new column:

https://dune.com/queries/3742749

I imagine you will make a fork of this an maintain it on your own.

Since this was just a query update, no changes need to be made to the code here.

@olgafetisova
Copy link

I am currently updating the following query https://dune.com/queries/3665113 with adding bond_provider as mentioned above. The PR is created, once merged, the query will have bond mapping and will allow us to maintaining everything in one place.

@fleupold fleupold merged commit b61e2f4 into main Aug 16, 2024
1 check passed
@fleupold fleupold deleted the 24/remove-bond-map branch August 16, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary BOND_MAP environment variable
3 participants