Branch Enhancements #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update README.md
ensure instrumentation code becomes the new target
Check if the file HitsFilePath exists
Fix errors when using multiple referenced libraries.
CalculateCoverage: Fix file not foundexception
Check for totalLines to be 0 in CoverageSummary.
fix open cover reporter so that it uses unique ids over multiple modules
Fixes assembly resolution so it scans the module directory as well.
Minor refactorings elsewhere: * Inline functions to local functions. * Extract method for obtaining backup module path. * Avoid hard-coding coverlet assembly name.
As someone who never used code coverage it was not clear to me until I've read it in this post: https://medium.com/@tonerdo/setting-up-coveralls-with-coverlet-for-a-net-core-project-2c8ec6c5dc58
[Skip CI] Specify what project to add the NuGet
Additional coverage reporting for properties and nested types
|
@tonerdo - Merge conflicts fixed. |
sjp
reviewed
May 1, 2018
|
|
||
| var pathInstr = Instruction.Create(OpCodes.Ldstr, _result.HitsFilePath); | ||
| var markInstr = Instruction.Create(OpCodes.Ldstr, marker); | ||
| var callInstr = Instruction.Create(OpCodes.Call, processor.Body.Method.Module.ImportReference(typeof(CoverageTracker).GetMethod("MarkExecuted"))); |
There was a problem hiding this comment.
Can we change the ImportReference() call to use the one-off _markExecutedMethodLoader.Value too? Other than that this looks good!
|
Wow, I royally screwed something up here. I was working on my work laptop and somehow messed up the git history for this repo. I'm probably going to close this PR, delete my fork, and open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR covers a lot of changes in order to better support branch coverage. The main purpose of this refactor is two-fold. First, to add improved support for branch coverage. Second, to improve the output of the 3 supported report formats by adding previously missing information.
At a high level, this PR covers the objectives by:
CoverageDetailsresult model fromCoverageSummaryin report generators in lieu of manually tracking and incrementing visits and counts.