Avoid leaving file handles open #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids locking on file handles.
tonerdo
reviewed
Apr 26, 2018
| @@ -155,7 +154,7 @@ private bool IsBranchTarget(ILProcessor processor, Instruction instruction) | |||
| return false; | |||
| } | |||
|
|
|||
| private void ReplaceInstructionTarget(Instruction instruction, Instruction oldTarget, Instruction newTarget) | |||
| private static void ReplaceInstructionTarget(Instruction instruction, Instruction oldTarget, Instruction newTarget) | |||
There was a problem hiding this comment.
Any particular reason you made this static?
There was a problem hiding this comment.
No reason aside from them not relying on any fields in the class. It's not a functional change in behavior, mostly cosmetic.
tonerdo
approved these changes
Apr 28, 2018
NorekZ
pushed a commit
to NorekZ/coverlet
that referenced
this pull request
Nov 8, 2018
Avoid leaving file handles open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calculating code coverage for a solution of mine, I found that two projects where reliably stuck on file locking.
The only process using the files were the
dotnetprocess running code coverage reporting. After wrapping disposable objects inusingstatements, the problem appears to be resolved.Additionally, I think this may also allow the
RetryHelpercode to be removed, but this has not been done yet.