Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for assemblies with embedded PDBs #259

Merged
merged 2 commits into from
Dec 8, 2018
Merged

Conversation

tonerdo
Copy link
Collaborator

@tonerdo tonerdo commented Dec 8, 2018

No description provided.

@codecov
Copy link

codecov bot commented Dec 8, 2018

Codecov Report

Merging #259 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #259      +/-   ##
==========================================
+ Coverage   95.43%   95.44%   +0.01%     
==========================================
  Files          16       16              
  Lines        1752     1757       +5     
==========================================
+ Hits         1672     1677       +5     
  Misses         80       80
Impacted Files Coverage Δ
src/coverlet.core/Helpers/InstrumentationHelper.cs 98.76% <100%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d35a5...553d201. Read the comment docs.

@tonerdo tonerdo merged commit 4ead796 into master Dec 8, 2018
@tonerdo tonerdo deleted the embedded-pdbs branch December 17, 2018 09:10
@pape77
Copy link
Contributor

pape77 commented Dec 22, 2018

Is it an idea that this is an option to enable or not? Now there's things like "xunit" dlls getting instrumented, or others which are used in tests maybe and we don't care at all for coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants