#254 Fix TeamCity reporter decimal separator (i18n) #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unning under i18n settings with comma instead of period as decimal separator. TeamCity will error out if the output value is not using period as decimal separato, so this fix will make sure to always use period as decimal separator when reporting to TeamCity
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 16 16
Lines 1752 1752
=======================================
Hits 1672 1672
Misses 80 80
Continue to review full report at Codecov.
|
tonerdo
approved these changes
Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TeamCity will error out if the output value is not using period as decimal separator, so this fix will make sure to always use period as decimal separator when reporting to TeamCity