Add option for additional assembly probe dirs #253
Conversation
ViktorHofer
force-pushed
the
ProbePath
branch
2 times, most recently
from
ae4cbdc to
e973b79
Compare
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 95.29% 95.43% +0.14%
==========================================
Files 16 16
Lines 1699 1752 +53
==========================================
+ Hits 1619 1672 +53
Misses 80 80
Continue to review full report at Codecov.
|
|
@ViktorHofer I believe #213 already addresses this? |
|
You are absolutely right, I missed that PR. I think both PRs present individual benefits. I will incorporate my changes into @jherby2k's PR. |
…roject references can also be instrumented.
…ple locations is already supported in the master branch.
ViktorHofer
force-pushed
the
ProbePath
branch
from
e973b79 to
1e05a04
Compare
| { | ||
| document.Value.Branches.Remove(branchToRemove.Key); | ||
| } | ||
| // for MoveNext() compiler autogenerated method we need to patch false positive (IAsyncStateMachine for instance) |
There was a problem hiding this comment.
These are white-space only changes that are wrong in upstream.
ViktorHofer
force-pushed
the
ProbePath
branch
from
1e05a04 to
a7a27e7
Compare
|
Can you just add ViktorHofer@3c480c7 to this? I'm so over my head with this complex PR stuff. |
|
That is already part of the changes or am I missing something? |
|
As I said I’m completely confused at this point. I added that commit last night to my now fubar’d PR.
I’m not looking at coverlet any more at this point. if this ever makes it into a release, cool.
|
|
@jherby2k no worries, your contributions are already included in this PR. I'll do one final sweeping review, your contribution is greatly appreciated |
|
@jherby2k your commits are cherry-picked into this PR, you are still the author of the commits and 50% of the work is yours. If I crossed a line please tell me, we usually work this way in our team, therefore I wasn't aware that I could be insensitive.
Because of the way this PR moved forward or because you don't need it anymore? @tonerdo thanks a lot 👍 |
|
No no, its all good. I’m just having a frustrating day in general. Thanks for your contribution!
|
|
Ok got it. Hope it'll get better soon :) |
|
@tonerdo Thanks for the through feedback. I addressed all your comments. Hope we can get this into master now. Additionally I have an ask: Can we please publish a new version to either an internal feed (myget) or nuget (preferably nuget) after this is in? Thanks a lot! |
|
Sure @ViktorHofer, will merge and publish once I get an answer to my little nit above and the CI passes |
ViktorHofer
force-pushed
the
ProbePath
branch
from
bc5d2dc to
89f5be5
Compare
|
@tonerdo it seems CI failed. Can you re-run CI? |
|
Also I see that your appveyor script still uses VS 2015 instances. I suggest updating to 2017 or "even better", consider using Azure DevOps. |
Hehehe, shameless plug 😄 |
|
@ViktorHofer there's a new release with these changes |
|
Amazing, thanks 😊 |
|
Thanks fellas!
|
Adds an optional argument to probe for additional assemblies at a different location than the test assembly's directory. This is needed for corefx but should also be useful for advanced scenarios in regular .NET apps.
cc @tonerdo