Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Merge #204 !
@tonerdo So after playing a bit more around with my last change (which is already merged #204) , I realized I made a fuck-up because despite i was comparing by filename, you were already storing the keys for the
Modules
dictionary as complete paths inCoverage.cs
.This caused the comparison I modified in #204 to asume the keys for
modules
andModules
were the same. But i didn't change the values of these keys to be only the file name too, so they still had the complete path on it (and therefore, were different) .As it tries to access the dictionary with the wrong key (asuming they were the same in both
modules
andModules
) it crashes.If you see the different commits maybe it helps to understand what I was aiming to achieve.
The solution was much simpler. Now I just store the module keys with
Path.GetFileName
inCoverage.cs
, so they can be correctly matched inCoverageResult.cs
as it was done before my change.I already tested it locally and worked for me for the example on issue #203
Hope this is clear enough!
Here's the output. Please merge!