Propose rule disabling

[erikshestopal]

On Commercial, we have a lot of imports that following this format:

import UI from '@commercial/constants/ui';

and eslint flags these lines as:

1. Unable to resolve path to module '@commercial/constants/ui'
2. '@commercial/constants' should be listed in the project's dependencies.
3. Missing file extension for "@commercial/constants/ui

I propose that we disable these three rules as we don't use file extensions in our imports and because the @commercial/blah pattern is very common and used everywhere in the code base.

Suggestions, feedback and alternatives welcome!

[gettinToasty]

marking our aliases with @ got rid of the "should be listed in the project's dependencies." violation for us, but there's an alternative fix:

import-js/eslint-plugin-import#89 (comment)

(i was actually just looking into this issue yesterday and this plugin seems promising)

[erikshestopal]

@gettinToasty something like this?

["module-resolver", {
      "root": ["."],
      "cwd": "babelrc",
      "extensions": [".js", ".jsx"],
      "alias": {
        "@commercial": "./app/assets/javascripts/client",
        "@shared": "./app/assets/javascripts/shared"
      }
    }]

[gettinToasty]

specifically talking about this:

Just published 0.11 with the optional Webpack resolver plugin. To have the linter read your aliases, just add import/resolver: webpack as a setting in your .eslintrc and make sure to install eslint-import-resolver-webpack wherever the plugin is installed (globally or dev dependency or what have you).

[erikshestopal]

Closing since we are moving towards removing react-treat.

[gettinToasty]

i'm not sure what removing react-treat has to do with this? i know at least in our project we have a bunch of locally aliased names and i'm pretty sure commercial does too?

see: all dis shit

[erikshestopal]

@gettinToasty oh sorry, wrong repo lol!

[albertovillalobos]

@ThisIsErik lol

[berfarah]

Are there any extensions of eslint that would be able to take webpack configuration into account for resolving imports?

[gettinToasty]

@berfarah thats literally what i just linked to above lol

[berfarah]

My bad, I missed it