github actions; all projects #11
Conversation
There was a problem hiding this comment.
I'm quite uncomfortable with the 8 copy pastes. A single update will take 9 times longer to write and will also be longer to review. Moreover, if you add more packages, like coveo-magic, well that's a copy-paste more. We should at least discuss the possibility to use a local action with parameterized name. A typical counterargument against this approach is
Yeah, but what if I want to make
.github/workflows/coveo-systools.hmldifferent?
and the counterargument to that counterargument is that, of course, you can. Once the local action is written, you still have the option to use it or not.
| @@ -11,6 +11,8 @@ | |||
| from coveo_testing.parametrize import parametrize | |||
| from coveo_testing.temporary_resource.unique_id import TestId, unique_test_id | |||
|
|
|||
| _ = unique_test_id # mark fixtures are used | |||
There was a problem hiding this comment.
Did you mean
| _ = unique_test_id # mark fixtures are used | |
| _ = unique_test_id # mark fixtures as used | |
?
(I feel like an auto-correct 😆)
| with: | ||
| project-name: ${{ github.workflow }} | ||
| pypi-token: ${{ secrets.PYPI_TOKEN }} | ||
| dry-run: ${{ github.ref != 'refs/heads/main' }} |
There was a problem hiding this comment.
I'm starting to guess that I'll review the same workflow with different name and paths. Perhaps you can write a local composite-action with parameterized name? I think you'd reap the benefit after you decide to update the workflows 2-3 times (for instance to update python-version).
Originally I wanted to do composites but it was more problems than not. Is the "local action" à composite? For instance I couldn't call uses: python setup from a composite. |
C'est dommage ça. Il y a déjà un issue d'ouvert qui demande qu'on puisse faire ça si tu veux faire +1 🙂. |
Co-authored-by: Jeff Smith <jfsmith@coveo.com> Co-authored-by: Kevin Lalumiere <kevin.lalumiere@gmail.com>
Feature/readme
This enables tests and publish on all projects.
There's a really weird behavior on mac where
platform.node()changes from a.to a-mid execution. 🤷🏻♂️Other than that, even though docker is installed on github action machines, they're configured for non-linux containers. The docker tests will fail trying to build the dockerfile. So I skipped those tests unless we're on linux.
The readmes were created just for the sake of the pyproject.toml and will be updated through #10