-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(quantic): added playwright tests and unit test for quantic generated answer component #4803
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
.../quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/quanticGeneratedAnswer.e2e.ts
Outdated
Show resolved
Hide resolved
…swer/e2e/quanticGeneratedAnswer.e2e.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestions but pretty much there!
packages/quantic/cypress/e2e/default-2/generatedAnswer/generated-answer-selectors.ts
Outdated
Show resolved
Hide resolved
...c/force-app/main/default/lwc/quanticGeneratedAnswer/__tests__/quanticGeneratedAnswer.test.js
Outdated
Show resolved
Hide resolved
...c/force-app/main/default/lwc/quanticGeneratedAnswer/__tests__/quanticGeneratedAnswer.test.js
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/e2e/pageObject.ts
Show resolved
Hide resolved
...ges/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess what @mmitiche, I found another cool thing Playwright offers :D
https://playwright.dev/docs/locators#locate-by-test-id
If you set data-testId
on your HTML elements, you can simply do getByTestId('')
to locate an element. instead of having to do '[data-test="generated-answer__copy-to-clipboard"]' for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some modifications to use the getByTestId
selector from playwright mainly.
Updated one selector to use getByRole
too
SFINT-5789
Unit tests:
E2E tests