fix(atomic): replace set polyfill in-house for size optimization #4550
+13
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
requested review from
olamothe,
fpbrault,
y-lakhdar and
fbeaudoincoveo
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
approved these changes
Oct 17, 2024
fbeaudoincoveo
approved these changes
Oct 17, 2024
| @@ -0,0 +1,10 @@ | |||
| // TODO: Replace by Set.prototype.intersection in July 2025 | |||
| export function intersection<T>(setA: Set<T>, setB: Set<T>): Set<T> { | |||
There was a problem hiding this comment.
Where did you take the implementation?
Shouldn't we unit-test it if it's in-house?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.