-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(atomic): Add insight result attach-to-case component #4499
Open
jfallaire
wants to merge
12
commits into
master
Choose a base branch
from
SVCINT-3044
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+326
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfallaire
requested review from
olamothe,
fpbrault,
y-lakhdar and
alexprudhomme
October 7, 2024 13:30
This comment was marked as resolved.
This comment was marked as resolved.
SimonMilord
approved these changes
Oct 7, 2024
...onents/insight/atomic-insight-result-attach-to-case/atomic-insight-result-attach-to-case.tsx
Outdated
Show resolved
Hide resolved
...onents/insight/atomic-insight-result-attach-to-case/atomic-insight-result-attach-to-case.tsx
Outdated
Show resolved
Hide resolved
...rc/components/insight/atomic-insight-result-action-bar/atomic-insight-result-action-bar.pcss
Outdated
Show resolved
Hide resolved
...onents/insight/atomic-insight-result-attach-to-case/atomic-insight-result-attach-to-case.tsx
Outdated
Show resolved
Hide resolved
…n-bar and atomic-insight-result-attach-to-case components
mmitiche
reviewed
Oct 8, 2024
...onents/insight/atomic-insight-result-attach-to-case/atomic-insight-result-attach-to-case.tsx
Outdated
Show resolved
Hide resolved
...onents/insight/atomic-insight-result-attach-to-case/atomic-insight-result-attach-to-case.tsx
Outdated
Show resolved
Hide resolved
…nt to atomic-insight-result-attach-to-case-action and add new one for attach-to-case-indicator
…insight-result-attach-to-case-action component
jfallaire
temporarily deployed
to
PR Artifacts
October 11, 2024 18:27
— with
GitHub Actions
Inactive
jfallaire
temporarily deployed
to
PR Artifacts
October 15, 2024 13:40
— with
GitHub Actions
Inactive
jfallaire
temporarily deployed
to
PR Artifacts
October 16, 2024 17:48
— with
GitHub Actions
Inactive
mikegron
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the AtomicInsightResultAttachToCase component, which emits two distinct events:
atomic/insight/attachToCase/attach
atomic/insight/attachToCase/detach
By listening to these events, you will gain access to the attachToCase controller and the associated result.
The component can also be used as a visual indicator when results are attached (readonly prop)