-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(headless commerce): retrieve clientId from Relay instead of coveoua when building commerce API requests #4111
Conversation
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
Just noticed the query suggest request was forgotten: ui-kit/packages/headless/src/features/commerce/query-suggest/query-suggest-actions.ts Lines 67 to 79 in c9822ed
|
Good catch @Spuffynism ! Fixing |
…4126) https://coveord.atlassian.net/browse/KIT-3351 We now instead rely on the default browser navigator context provider to retrieve the client ID from Relay in a client-side rendering scenario. In a server-side rendering scenario, the implementer would be responsible for retrieving the client ID from the request headers (or generating one), returning this value in their navigator context provider function, as well as in the response headers. This reverts most of the changes I made in #4111. I also applied the same logic to the search engine, which reverts many of the changes made by @louis-bompart in #3820. These changes were made in a separate commit, however, so we can easily revert them and keep the scope to headless/commerce if we prefer.
https://coveord.atlassian.net/browse/KIT-3335