Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atomic): use currency from context instead of prop for atomic-product-price #4091

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

olamothe
Copy link
Member

Remove currency as a property from atomic-product-price, as it it mandatory to configure it from Headless, and it should be the source of truth in all scenarios.

https://coveord.atlassian.net/browse/KIT-3317

@olamothe olamothe requested a review from a team as a code owner June 13, 2024 20:34
@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jun 13, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 204.8 204.8 0
commerce 292.6 292.6 0
search 372.3 372.3 0
insight 352.3 352.3 0
product-listing 266.9 266.9 0
product-recommendation 170.8 170.8 0
recommendation 217.8 217.8 0
ssr 365.1 365.1 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@louis-bompart
Copy link
Collaborator

react sample commerce to update ;)

@olamothe olamothe enabled auto-merge June 17, 2024 13:28
@olamothe olamothe added this pull request to the merge queue Jun 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 17, 2024
@olamothe olamothe added this pull request to the merge queue Jun 17, 2024
Merged via the queue into master with commit 1bfee6b Jun 17, 2024
87 checks passed
@olamothe olamothe deleted the KIT-3317 branch June 17, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants