fix(atomic): collapsed answer gradient colour #4081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, and if you want to have a look, you can do so with this branch: https://github.com/coveo/ui-kit/compare/KIT-3313-test |
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
olamothe
approved these changes
Jun 11, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Spuffynism
pushed a commit
that referenced
this pull request
Jun 14, 2024
https://coveord.atlassian.net/browse/KIT-3313 Right now, the linear-gradient is hardcoded to white rather than to the background atomic colour. This will create issues when clients modify their background colour to something other than white, like we doc on the docs site when in dark mode. <img width="1222" alt="Screenshot 2024-06-11 at 3 34 27 PM" src="https://github.com/coveo/ui-kit/assets/39384459/967e0fdc-923d-4554-a290-a795c7b66b66"> It doesn't seem possible for clients to change the linear-gradient. Probably because it requires targeting a pseudo-element of a part with a certain class. So, in this PR, I use the atomic-background colour instead.
fpbrault
pushed a commit
that referenced
this pull request
Jun 14, 2024
https://coveord.atlassian.net/browse/KIT-3313 Right now, the linear-gradient is hardcoded to white rather than to the background atomic colour. This will create issues when clients modify their background colour to something other than white, like we doc on the docs site when in dark mode. <img width="1222" alt="Screenshot 2024-06-11 at 3 34 27 PM" src="https://github.com/coveo/ui-kit/assets/39384459/967e0fdc-923d-4554-a290-a795c7b66b66"> It doesn't seem possible for clients to change the linear-gradient. Probably because it requires targeting a pseudo-element of a part with a certain class. So, in this PR, I use the atomic-background colour instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-3313
Right now, the linear-gradient is hardcoded to white rather than to the background atomic colour. This will create issues when clients modify their background colour to something other than white, like we doc on the docs site when in dark mode.
It doesn't seem possible for clients to change the linear-gradient. Probably because it requires targeting a pseudo-element of a part with a certain class. So, in this PR, I use the atomic-background colour instead.