Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atomic): clear recent searches on keyboard enter keypress #4072

Merged
merged 12 commits into from
Jun 20, 2024

Conversation

fbeaudoincoveo
Copy link
Contributor

@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jun 10, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 204.9 204.9 0
commerce 293.1 293.1 0
search 372.4 372.4 0
insight 352.4 352.4 0
product-listing 266.9 266.9 0
product-recommendation 170.8 170.8 0
recommendation 217.8 217.8 0
ssr 365.2 365.2 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Copy link
Member

@olamothe olamothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change seems fine after testing locally.
It means we are missing a cypress test for this though.

It should be done by default when fixing any kind of bugs, and only an exception to not add one (ie: very hard to reproduce/setup/automate), with a PR explanation as to why it was not added !

Copy link
Contributor

@y-lakhdar y-lakhdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces the bug fixed by #3582 but for some reason the Cypress tests are all green.
I guess the E2E tests where not good enough.

I added the E2E test in this ##4093 to prevent reintroducing this issue in the commerce-searchbox

@y-lakhdar
Copy link
Contributor

y-lakhdar commented Jun 14, 2024

@olamothe

Code change seems fine after testing locally.

Does that mean you are not reproducing the bug from #3582?

It means we are missing a cypress test for this though.

I agree. I actually added one in cypress... that's why I don't understand how it passed. Anyway, I will be revisiting the Cypress test
I also added one in Playwright (#4093)

Copy link
Contributor

@y-lakhdar y-lakhdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fbeaudoincoveo fbeaudoincoveo added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@fbeaudoincoveo fbeaudoincoveo added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@fbeaudoincoveo fbeaudoincoveo merged commit 9ab7ba5 into master Jun 20, 2024
85 of 87 checks passed
@fbeaudoincoveo fbeaudoincoveo deleted the KIT-3234 branch June 20, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants