-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(atomic): start tests on atomic-commerce-facets #4071
Conversation
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not fond of those tests/utils if I'm perfectly honest.
I think we should try to adhere more closely to the modern test philosophy shared across all modern test frameworks, which entails testing user-visible behaviour.
https://playwright.dev/docs/best-practices#test-user-visible-behavior
https://testing-library.com/docs/guiding-principles
What does that mean for this PR?
packages/atomic/src/components/commerce/facets/atomic-commerce-facets/e2e/page-object.ts
should have locators built around the facet labels- The utils should make lighter uses of the hydrated selector.
Mostly: Add new
base-page-object
to inherit from for each tests, which should simplify/streamline the "load this story for this component with these arguments in the URL" repetitive pattern.https://coveord.atlassian.net/browse/KIT-3256