Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update search action cause to browseResults in insight-search and pagination #4068

Merged
merged 4 commits into from
Jun 15, 2024
Merged

feat: update search action cause to browseResults in insight-search and pagination #4068

merged 4 commits into from
Jun 15, 2024

Conversation

louis-bompart
Copy link
Collaborator

The search action cause pagerScrolling has been updated to browseResults in the insight-search and pagination features. This change ensures consistent logging of user navigation actions.

https://coveord.atlassian.net/browse/KIT-2983

@louis-bompart louis-bompart requested a review from a team as a code owner June 10, 2024 17:02
@louis-bompart louis-bompart requested review from olamothe, fpbrault, fbeaudoincoveo and mmitiche and removed request for olamothe, fpbrault and fbeaudoincoveo June 10, 2024 17:02
@developer-experience-bot
Copy link
Contributor

developer-experience-bot bot commented Jun 10, 2024 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 204.8 204.8 0
commerce 292.6 292.6 0
search 372.3 372.3 0
insight 352.4 352.3 0
product-listing 266.9 266.9 0
product-recommendation 170.8 170.8 0
recommendation 217.8 217.8 0
ssr 365.1 365.1 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

mmitiche
mmitiche approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

This single line will need to be updated accordingly to allow the Quantic E2E tests to pass successfully:

ui-kit/packages/quantic/cypress/e2e/default-1/examples/insight-panel/insight-panel.cypress.ts

Line 90 in 35e1517

'pagerNumber',

@louis-bompart
feat: update search action cause to browseResults in insight-search a…
239dad2 
…nd pagination

The search action cause `pagerScrolling` has been updated to `browseResults` in the `insight-search` and `pagination` features. This change ensures consistent logging of user navigation actions.

https://coveord.atlassian.net/browse/KIT-2983
@louis-bompart
derp
b2ee245 
https://coveord.atlassian.net/browse/KIT-2983
@louis-bompart
fix legacy analytics pager in insight
c9ed53b 
https://coveord.atlassian.net/browse/KIT-2983
@louis-bompart louis-bompart added this pull request to the merge queue Jun 15, 2024
Merged via the queue into master with commit a5ee23a Jun 15, 2024
92 checks passed
@louis-bompart louis-bompart deleted the feat/KIT-2983 branch June 15, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmitiche mmitiche mmitiche approved these changes

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@samisayegh samisayegh samisayegh approved these changes

@olamothe olamothe olamothe approved these changes

@fpbrault fpbrault Awaiting requested review from fpbrault

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@louis-bompart @olamothe @samisayegh @fbeaudoincoveo @mmitiche