Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: atomic-commerce-searchbox (playwright demo) #4033

Merged
merged 4 commits into from
Jun 4, 2024
Merged

test: atomic-commerce-searchbox (playwright demo) #4033

merged 4 commits into from
Jun 4, 2024

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented May 30, 2024 •
edited
Loading

@louis-bompart louis-bompart changed the base branch from master to playwright-setup May 30, 2024 21:07
@louis-bompart louis-bompart force-pushed the playwright-setup branch 2 times, most recently from 38effdd to 4fa4961 Compare May 30, 2024 21:09
@github-actions GitHub Actions
Copy link

github-actions bot commented May 30, 2024 •
edited by developer-experience-bot bot
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 202.8 202.8 0
commerce 285.9 285.9 0
search 367.4 367.4 0
insight 347.7 347.7 0
product-listing 262.2 262.2 0
product-recommendation 171.9 171.9 0
recommendation 215.8 215.8 0
ssr 360.2 360.2 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 7 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@louis-bompart louis-bompart changed the title Playwright demo test: atomic-commerce-searchbox (playwright demo) May 31, 2024
@louis-bompart louis-bompart marked this pull request as ready for review May 31, 2024 00:04
@louis-bompart louis-bompart requested a review from a team as a code owner May 31, 2024 00:04
@louis-bompart louis-bompart requested review from olamothe, y-lakhdar and fbeaudoincoveo and removed request for a team May 31, 2024 00:04
@louis-bompart louis-bompart requested review from lvu285 and mmitiche May 31, 2024 17:03
github-merge-queue bot pushed a commit that referenced this pull request May 31, 2024
@louis-bompart
tests: setup playwright (#4032)
e1905e5 
Initial setup of playwright

See #4033 for a test demoing the "result" and good practice.
Base automatically changed from playwright-setup to master May 31, 2024 19:06
olamothe
olamothe approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@olamothe olamothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty clean !

...ges/atomic/src/components/commerce/atomic-commerce-search-box/atomic-commerce-search-box.tsx Show resolved Hide resolved
...mic/src/components/commerce/atomic-commerce-search-box/e2e/atomic-commerce-search-box.e2e.ts Show resolved Hide resolved
mmitiche
mmitiche approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat in my opinion, clear and simple! Liked the accessibility tests that are added in a very simple fashion 👌

...mic/src/components/commerce/atomic-commerce-search-box/e2e/atomic-commerce-search-box.e2e.ts Show resolved Hide resolved
@louis-bompart louis-bompart requested a review from olamothe June 4, 2024 03:25
@louis-bompart louis-bompart enabled auto-merge June 4, 2024 03:25
@louis-bompart louis-bompart added this pull request to the merge queue Jun 4, 2024
Merged via the queue into master with commit 7aa6094 Jun 4, 2024
92 checks passed
@louis-bompart louis-bompart deleted the playwright-demo branch June 4, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmarceau jpmarceau jpmarceau left review comments

@mmitiche mmitiche mmitiche approved these changes

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

@fbeaudoincoveo fbeaudoincoveo Awaiting requested review from fbeaudoincoveo fbeaudoincoveo is a code owner automatically assigned from coveo/search

@lvu285 lvu285 Awaiting requested review from lvu285

@olamothe olamothe Awaiting requested review from olamothe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@louis-bompart @olamothe @jpmarceau @mmitiche