-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/commerce searchbox #4030
Closed
Closed
Test/commerce searchbox #4030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Report PR Title ❌ Title should follow the conventional commit spec: (optional scope): Example: feat(headless): add result-list controller Bundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
louis-bompart
force-pushed
the
test/commerce-searchbox
branch
2 times, most recently
from
May 29, 2024 23:29
9d2e9ac
to
16ad16d
Compare
louis-bompart
force-pushed
the
nx-storybook
branch
from
May 30, 2024 02:37
2ac9442
to
8362e31
Compare
Implements significant updates to Storybook configurations and introduces new story formats for Atomic components. - Adds new dependencies for Storybook, including `@nx/storybook`, `@storybook/addon-essentials`, and others to enhance Storybook functionality. - Updates `.gitignore`, `.prettierignore`, and `nx.json` to support new Storybook configurations and file structures. - Introduces new `.storybook` configuration files and TypeScript configurations for Storybook, enabling improved development workflows. - Migrates `atomic-breadbox` and `atomic-result-image` components to new Storybook story formats, showcasing usage with `.new.stories.tsx` files. - Implements utility functions `render-component.tsx`, `result-wrapper.tsx`, and `search-interface-wrapper.tsx` in `storybookUtils` to streamline story creation and rendering. - Adjusts ESLint configurations to accommodate new file structures and Storybook setup. - Removes outdated stories and updates package configurations to reflect new Storybook integration and component testing capabilities. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/coveo/ui-kit/pull/3980?shareId=c92c6bad-6cfe-43cb-8523-3e7c926d6a61).
louis-bompart
force-pushed
the
test/commerce-searchbox
branch
from
May 30, 2024 03:11
16ad16d
to
361c73c
Compare
louis-bompart
had a problem deploying
to
PR Artifacts
May 30, 2024 19:34 — with
GitHub Actions
Failure
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
louis-bompart
had a problem deploying
to
PR Artifacts
May 31, 2024 07:34 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.