Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/commerce searchbox #4030

Closed
wants to merge 69 commits into from
Closed

Test/commerce searchbox #4030

wants to merge 69 commits into from

Conversation

louis-bompart
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented May 29, 2024

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:

(optional scope):

Example:

feat(headless): add result-list controller

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 202.8 202.8 0
commerce 285.2 285.2 0
search 367.4 367.4 0
insight 347.8 347.8 0
product-listing 262.3 262.3 0
product-recommendation 171.9 171.9 0
recommendation 215.8 215.8 0
ssr 360.3 360.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 7 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@louis-bompart louis-bompart force-pushed the test/commerce-searchbox branch 2 times, most recently from 9d2e9ac to 16ad16d Compare May 29, 2024 23:29
louis-bompart and others added 13 commits May 29, 2024 22:37
Implements significant updates to Storybook configurations and introduces new story formats for Atomic components.
- Adds new dependencies for Storybook, including `@nx/storybook`, `@storybook/addon-essentials`, and others to enhance Storybook functionality.
- Updates `.gitignore`, `.prettierignore`, and `nx.json` to support new Storybook configurations and file structures.
- Introduces new `.storybook` configuration files and TypeScript configurations for Storybook, enabling improved development workflows.
- Migrates `atomic-breadbox` and `atomic-result-image` components to new Storybook story formats, showcasing usage with `.new.stories.tsx` files.
- Implements utility functions `render-component.tsx`, `result-wrapper.tsx`, and `search-interface-wrapper.tsx` in `storybookUtils` to streamline story creation and rendering.
- Adjusts ESLint configurations to accommodate new file structures and Storybook setup.
- Removes outdated stories and updates package configurations to reflect new Storybook integration and component testing capabilities.


---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/coveo/ui-kit/pull/3980?shareId=c92c6bad-6cfe-43cb-8523-3e7c926d6a61).
@louis-bompart louis-bompart force-pushed the test/commerce-searchbox branch from 16ad16d to 361c73c Compare May 30, 2024 03:11
Base automatically changed from nx-storybook to master May 30, 2024 03:17
Copy link

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:
<type>(optional scope): <description>

Example: feat(headless): add result-list controller

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 202.8 202.8 0
commerce 285.5 285.5 0
search 367.4 367.4 0
insight 347.8 347.8 0
product-listing 262.3 262.3 0
product-recommendation 171.9 171.9 0
recommendation 215.8 215.8 0
ssr 360.3 360.3 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 7 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant