feat(quantic): rich text formatting for quantic RGA #4015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added marked as static resource fixed build warning in quanticCitation.js modified quanticGeneratedAnswer to specify it supports markdown
Styling added for the new markdown answer
lbergeron
reviewed
May 28, 2024
...ic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js
Outdated
Show resolved
Hide resolved
fixed issue with empty <p> in <li>
erocheleau
requested review from
SimonMilord,
mmitiche,
olamothe,
y-lakhdar and
fbeaudoincoveo
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support product-recommendation : missing SSR support product-listing : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
erocheleau
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
mmitiche
reviewed
Jun 13, 2024
...ic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js
Show resolved
Hide resolved
...ic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js
Outdated
Show resolved
Hide resolved
...ic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/quanticGeneratedAnswer.js
Outdated
Show resolved
Hide resolved
...ic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js
Show resolved
Hide resolved
...in/default/lwc/quanticGeneratedAnswerContent/__tests__/quanticGeneratedAnswerContent.test.js
Outdated
Show resolved
Hide resolved
...in/default/lwc/quanticGeneratedAnswerContent/__tests__/quanticGeneratedAnswerContent.test.js
Show resolved
Hide resolved
...in/default/lwc/quanticGeneratedAnswerContent/__tests__/quanticGeneratedAnswerContent.test.js
Show resolved
Hide resolved
...in/default/lwc/quanticGeneratedAnswerContent/__tests__/quanticGeneratedAnswerContent.test.js
Show resolved
Hide resolved
SimonMilord
reviewed
Jun 13, 2024
packages/quantic/force-app/main/default/lwc/quanticUtils/markdownUtils.js
Show resolved
Hide resolved
SimonMilord
reviewed
Jun 13, 2024
packages/quantic/force-app/main/default/lwc/quanticUtils/markdownUtils.js
Outdated
Show resolved
Hide resolved
SimonMilord
reviewed
Jun 13, 2024
packages/quantic/force-app/main/default/lwc/quanticUtils/markdownUtils.js
Outdated
Show resolved
Hide resolved
SimonMilord
reviewed
Jun 13, 2024
...ges/quantic/force-app/main/default/lwc/quanticGeneratedAnswer/templates/generatedAnswer.html
Show resolved
Hide resolved
erocheleau
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
SimonMilord
approved these changes
Jun 20, 2024
mmitiche
reviewed
Jun 20, 2024
...ic/force-app/main/default/lwc/quanticGeneratedAnswerContent/quanticGeneratedAnswerContent.js
Show resolved
Hide resolved
mmitiche
approved these changes
Jun 20, 2024
erocheleau
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
erocheleau
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
erocheleau
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
erocheleau
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
louis-bompart
approved these changes
Jun 25, 2024
fbeaudoincoveo
approved these changes
Jun 25, 2024
packages/quantic/cypress/e2e/default-2/generatedAnswer/generated-answer.cypress.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SFINT-5459
Rich Text Formatting supported within the Quantic RGA component.
Very similar in essence to what @lbergeron did.
Some tweaks and changes were made to the styling of the rendered HTML based on Salesforce design system.
Unit tests were made for the new components and code, but i can't find a good way to create e2e tests for this feature.
It heavily depends on first receiving an EventStream message to set the answerType, and THEN renders markdown as HTML. We don't have the setup to be able to mock two consecutive RGA EventStream events, only one.
Some examples of rendered HTML:
Code blocks
Table: has a maximum height and is scrollable horizontally and vertically
Different levels of headers, all headers are repleaced with
h1,h2,h3,etc.elements in order to not break headings hierarchy in the page and break accessibility rules:Inline code
With Collapse = true
Added some Cypress tests too!
I am covering most of the "irregular" cases where we differ from the simple behavior of the
markedlibrary.