Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pipe stdout from dep-pipeline #3714

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Mar 14, 2024

@louis-bompart louis-bompart requested a review from a team as a code owner March 14, 2024 01:00
@louis-bompart louis-bompart merged commit 0131531 into master Mar 14, 2024
5 checks passed
@louis-bompart louis-bompart deleted the dep-pipeline-stdout branch March 14, 2024 01:00
Comment on lines 25 to 41
console.log(execSync(`
docker run -v ${resolve('.')}:/home/jenkins -a stderr -a stdout 458176070654.dkr.ecr.us-east-2.amazonaws.com/jenkins/deployment_package:stable
deployment-package package create --with-deploy \
--resolve HEADLESS_MAJOR_VERSION=${headless.major} \
--resolve HEADLESS_MINOR_VERSION=${headless.minor} \
--resolve HEADLESS_PATCH_VERSION=${headless.patch} \
--resolve ATOMIC_MAJOR_VERSION=${atomic.major} \
--resolve ATOMIC_MINOR_VERSION=${atomic.minor} \
--resolve ATOMIC_PATCH_VERSION=${atomic.patch} \
--resolve ATOMIC_REACT_MAJOR_VERSION=${atomicReact.major} \
--resolve ATOMIC_REACT_MINOR_VERSION=${atomicReact.minor} \
--resolve ATOMIC_REACT_PATCH_VERSION=${atomicReact.patch} \
--resolve ATOMIC_HOSTED_PAGE_MAJOR_VERSION=${atomicHostedPage.major} \
--resolve ATOMIC_HOSTED_PAGE_MINOR_VERSION=${atomicHostedPage.minor} \
--resolve ATOMIC_HOSTED_PAGE_PATCH_VERSION=${atomicHostedPage.patch} \
--resolve GITHUB_RUN_ID=${context.runId} \
--changeset ${releaseCommit}`.replaceAll(/\s+/g, ' ').trim());
--changeset ${releaseCommit}`.replaceAll(/\s+/g, ' ').trim()).toString());

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
.
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 218.6 218.6 0
commerce 308.4 308.4 0
search 380.6 380.6 0
insight 345.2 345.2 0
product-listing 313.2 313.2 0
product-recommendation 185.9 185.9 0
recommendation 233 233 0
ssr 374.2 374.2 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants